| 221 | | The rho result should look like the result presented above in the shortcomings section. The reason it doesn't may be due to modifying the eigen-structure of the equations, while keeping the form of the numerical flux the same... Another potential problem that I can think of other than typos, which seem to be absent, would be that the numerical flux isn't in terms of conserved quantities. But again, this seems to not be right given the theory that developed the equation, drew heavily upon conservative methods and integration.. I would be curious to add in the full expressions to this solver and see if it fixes things. However, I am planning on putting this in astrobear, so will instead focus on just writing an entropy correcting Roe Solver, which uses a different flux function given in Toro. |
| | 221 | The rho result should look like the result presented above in the shortcomings section. The reason it doesn't may be due to modifying the eigen-structure of the equations, while keeping the form of the numerical flux the same... Another potential problem that I can think of other than typos, which seem to be absent, would be that the numerical flux isn't in terms of conserved quantities. But again, this seems to not be right given the theory that developed the equation drew heavily upon conservative methods and integration.. I would be curious to add in the full expressions to this solver and see if it fixes things. However, I am planning on putting this in astrobear, so will instead focus on just writing an entropy correcting Roe Solver, which uses a different flux function given in Toro. |
